Repository navigation
Fix viewer menu, camera and section interactions - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Verification
Release build and 176 .NET tests on each of net8.0 and net10.0. Ran the real RVT CLI integration test.
163 viewer unit tests, 206 Chromium and Firefox Playwright tests, and DocFX with warnings as errors.
Re-exported Schependomlaan IFC (3,337 elements) and racbasicsampleproject RVT (467 elements). Checked keyboard selection and hiding, edited box persistence, edge-on drag and cube transitions in Chromium and Firefox. Capped exports with two test viewpoints verified the warning layout and hit targets at 320, 480, 1,024 and 1,280 px and verified Escape stops the tour before clearing the measurement or selection.
Adaptive orbit on Schependomlaan with the integrated Radeon was 16.7/16.8 ms p95 on the previous main and 16.8/16.8 ms on this commit, in two pairs with reversed run order. Both drew a median of 247,472 triangles.
Closes #16